Fix #618, stubs must not depend on real msgid implementation #674
+84
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CFE_SB_GetMsgId/SetMsgId functions, among others, were implemented as replicas of the actual FSW code. This creates a dependency on the actual definition of MsgId used by the mission. This makes the stub and actual stub. Stubs not actually read/write to the message in any way, they just manipulate a local (stored in the UT framework) out-of-band buffer to hold the metadata about the message. This revealed a few other minor issues in test cases where they were depending on values sitting in globals (fixed).
skliper
approved these changes
May 6, 2020
skliper
added
the
CCB:Ready
|
CCB 20200506 - Approved |
|
CCB 20200506 - APPROVED |
skliper
added
CCB-20200506
and removed
CCB:Ready
astrogeco
added
CCB:Approved
|
@jphickey does this necessitate an update to the sample_app unit tests? Looks like SAMPLE_ReportHousekeeping test is failing. |
jphickey
added a commit
that referenced
this pull request
May 11, 2020
For CFE_SB_SendMsg this was still reading the length directly from the header. It needs to use the metadata value instead.
|
Found the issue, see commit 6f06b16, the CFE_SB_SendMsg() stub needs to read the length from the metadata. Pushed directly to IC as hotfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This makes the SB stubs which access message structures into actual stubs, not a replica of the normal implementation. Stubs manipulate a local (stored in the UT framework) out-of-band buffer to hold the metadata about the message.
This removes the dependency on the actual definition of MsgId used by the mission and makes them agnostic to the setting of extended headers.
This revealed a few other minor issues in test cases where they were depending on values sitting in globals (also fixed).
Fixes #618
Testing performed
Build unit tests with SIMULATION=native ENABLE_UNIT_TESTS=TRUE with and without configuration for extended headers. Confirm passing.
Expected behavior changes
Unit tests now build and run when
MESSAGE_FORMAT_IS_CCSDS_VER_2is configured.System(s) tested on
Ubuntu 20.04 LTS 64 bit
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.